Episode 122: Providing Constructive Feedback

Effective negative feedback in software development requires shifting the focus from personal critique to objective constraints and technical requirements. When reviewing legacy code or pull requests, avoid attacking past or present developers, as this diminishes psychological safety and causes contributors to disengage. Instead, frame feedback around specific technical shortcomings, such as missing tests or failure to meet current requirements, while maintaining empathy for the historical context and constraints under which the original code was written. Utilizing the Socratic method—asking clarifying questions about how the code handles specific edge cases—allows developers to identify flaws independently, fostering a collaborative environment. This approach is equally applicable to UX design, where questioning how a flow addresses user needs or handles error states often yields more productive results than criticizing the design itself.